Skip to content

feat(vortex-spatial): add convex hull scalar function - #9219

Merged
HarukiMoriarty merged 4 commits into
developfrom
nemo/geo-convex-hull
Aug 12, 2026
Merged

feat(vortex-spatial): add convex hull scalar function#9219
HarukiMoriarty merged 4 commits into
developfrom
nemo/geo-convex-hull

Conversation

@HarukiMoriarty

@HarukiMoriarty HarukiMoriarty commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • add a strict native MultiPoint to Polygon convex-hull scalar function
  • delegate planar hull computation directly to geo::ConvexHull
  • preserve CRS and outer nullability while materializing native 2-D Polygon storage
  • use shared unary dispatch for constants and strict null propagation
  • cover empty, one-point, collinear, nullable, constant, and Q5-style collect-to-hull-to-area execution
  • add a dedicated convex-hull microbenchmark

Semantics

The return dtype is always native Polygon, including empty and degenerate hulls. Consistent with the current geometry-kernel policy, coordinate finiteness is unchecked unless validation is explicitly enabled; this function does not add per-call NaN validation.

@HarukiMoriarty HarukiMoriarty added the changelog/feature A new feature label Aug 5, 2026
@HarukiMoriarty HarukiMoriarty mentioned this pull request Aug 5, 2026
Open
@codspeed-hq

codspeed-hq Bot commented Aug 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will degrade performance by 23.13%

❌ 1 regressed benchmark
✅ 1973 untouched benchmarks
🆕 8 new benchmarks
⏩ 89 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Simulation decompress[u64, (10000, 4)] 310.1 µs 403.4 µs -23.13%
🆕 Simulation linestrings N/A 165.6 µs N/A
🆕 Simulation nullable_points N/A 301.9 µs N/A
🆕 Simulation points N/A 162.8 µs N/A
🆕 Simulation polygons N/A 168.3 µs N/A
🆕 Simulation eight_points N/A 3.7 ms N/A
🆕 Simulation nullable_eight_points N/A 3.7 ms N/A
🆕 Simulation sixty_four_points N/A 14.9 ms N/A
🆕 Simulation envelope_of_collected_points N/A 481.5 µs N/A

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.

Comparing nemo/geo-convex-hull (680ecb7) with develop (5e07c24)2

Open in CodSpeed

Footnotes

  1. 89 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on develop (6496a2c) during the generation of this report, so 5e07c24 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@HarukiMoriarty
HarukiMoriarty force-pushed the nemo/geo-convex-hull branch 2 times, most recently from 302bc8f to ddf9146 Compare August 6, 2026 20:15
@HarukiMoriarty HarukiMoriarty changed the title feat(vortex-geo): add convex hull scalar function feat(vortex-spatial): add convex hull scalar function Aug 7, 2026
connortsui20
connortsui20 approved these changes Aug 10, 2026
View reviewed changes

@connortsui20 connortsui20 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from nemo/geo-collect to develop August 12, 2026 14:25
@HarukiMoriarty
feat(vortex-geo): add convex hull scalar function
e2b8447 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
bench(vortex-geo): add convex hull benchmark
49e442d 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
fix(vortex-geo): materialize convex hull validity
0352f76 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
fix(vortex-spatial): use session Arrow conversion
680ecb7 
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
@HarukiMoriarty
HarukiMoriarty merged commit 4273f37 into develop Aug 12, 2026
74 of 75 checks passed
@HarukiMoriarty
HarukiMoriarty deleted the nemo/geo-convex-hull branch August 12, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connortsui20 connortsui20 connortsui20 approved these changes
@joseph-isaacs joseph-isaacs Awaiting requested review from joseph-isaacs

Assignees

No one assigned

Labels

changelog/feature A new feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HarukiMoriarty @connortsui20